Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chaining of imperative task dependency calls #3696

Merged
merged 2 commits into from Nov 20, 2020
Merged

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Nov 20, 2020

Summary

Returns self from imperative task dependency calls so they can be changed

Closes #3695

Changes

  • Changes return types of set_upstream, set_downstream, and set_dependencies from None to Task
  • Returns self from all the above

Importance

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@zanieb
Copy link
Contributor Author

zanieb commented Nov 20, 2020

This feels a little clunky but I haven't been a big user of the imperative API.

@joshmeek joshmeek merged commit 7402d75 into master Nov 20, 2020
@joshmeek joshmeek deleted the chain-set-upstream branch November 20, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain set_upstream with Task Results
3 participants