Add Bitbucket storage #3711
Merged
Add Bitbucket storage #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 24, 2020 21:23
Add support for Bitbucket as a file-based storage option alongside GitHub and GitLab. Prefect already supports registering and running of flows from GitHub/GitLab. Since Bitbucket is also a Git distribution and is fairly popular, the ability to run flows from a Bitbucket repo would be very useful and has an open issue (PrefectHQ#3343). The new Bitbucket option utilizes the atlassian-python-api package to connect to and retrieve flows from a Bitbucket repo on either Cloud or Server. Usage and installation is almost identical to GitLab and GitHub, except Bitbucket requires an additional argument, `project`, that is Bitbucket specific. Otherwise, installation occurs through the bitbucket extra and authentication is done through the BITBUCKET_ACCESS_TOKEN secret.
Add support for Bitbucket as a file-based storage option alongside GitHub and GitLab. Prefect already supports registering and running of flows from GitHub/GitLab. Since Bitbucket is also a Git distribution and is fairly popular, the ability to run flows from a Bitbucket repo would be very useful and has an open issue (PrefectHQ#3343). The new Bitbucket option utilizes the atlassian-python-api package to connect to and retrieve flows from a Bitbucket repo on either Cloud or Server. Usage and installation is almost identical to GitLab and GitHub, except Bitbucket requires an additional argument, `project`, that is Bitbucket specific. Otherwise, installation occurs through the bitbucket extra and authentication is done through the BITBUCKET_ACCESS_TOKEN secret.
Add support for Bitbucket as a file-based storage option alongside GitHub and GitLab. Prefect already supports registering and running of flows from GitHub/GitLab. Since Bitbucket is also a Git distribution and is fairly popular, the ability to run flows from a Bitbucket repo would be very useful and has an open issue (PrefectHQ#3343). The new Bitbucket option utilizes the atlassian-python-api package to connect to and retrieve flows from a Bitbucket repo on either Cloud or Server. Usage and installation is almost identical to GitLab and GitHub, except Bitbucket requires an additional argument, `project`, that is Bitbucket specific. Otherwise, installation occurs through the bitbucket extra and authentication is done through the BITBUCKET_ACCESS_TOKEN secret.
|
Here I am, brain the size of a planet and they ask me to welcome you to Prefect. So, welcome to the community @philz-catz! 🎉 🎉 |
added 6 commits
November 24, 2020 23:34
|
Here I am, brain the size of a planet and they ask me to welcome you to Prefect. So, welcome to the community @philz-catz! 🎉 🎉 |
joshmeek
reviewed
Dec 2, 2020
| @@ -143,6 +143,28 @@ GitLab storage uses a [personal access token](https://docs.gitlab.com/ee/user/pr | |||
| GitLab server users can point the `host` argument to their personal GitLab instance. | |||
| ::: | |||
|
|
|||
| ## Bitbucket | |||
There was a problem hiding this comment.
Could you move this to /orchestration/flow_config/storage.html? That is a new page where these details are organized
There was a problem hiding this comment.
I went ahead and copied it into flow_config/storage.md. Should I delete it from the exectution/storage_options.md?
added 3 commits
December 2, 2020 10:22
- Removed bitbucket-storage-label from local agent labels - Removed reference to label in bitbucket.py - Moved bitbucket storage documentation to flow_config
joshmeek
reviewed
Dec 2, 2020
| @@ -57,12 +57,6 @@ def __init__( | |||
| self.path = path | |||
| self.ref = ref | |||
|
|
|||
| super().__init__(**kwargs) | |||
There was a problem hiding this comment.
Oops looks like an accidental delete of the super 🙂
There was a problem hiding this comment.
Yup, I goofed that one. Also need to update the unit tests to remove the "bitbucket-flow-storage" label.
joshmeek
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Bitbucket as a file-based storage option alongside GitHub and GitLab.
Changes
Uses atlassian-python-api package ([https://github.com/atlassian-api/atlassian-python-api]) to allow Bitbucket to be used as a storage option.
Implementation is identical to GitLab but includes additional argument necessary for Bitbucket:
Importance
Bitbucket is a popular Git distribution and support has been requested (Issue #3343).
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)