New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SnowflakeQueryFromFile Task and SQLServerExecute Fix #4363
Conversation
This is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the SQLServerExecute
fix?
|
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
I believe this is done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I updated this. Couple of changes.
|
I'm a bit confused about the docs failure, can you push a commit to retrigger? |
except Exception as error: | ||
conn.close() | ||
raise error | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be entirely omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure, you mean to omit the entire except
block right? My concern was that the error won't be raised, but I guess it's passing the test for the error to pass through.
Summary
This creates a new task for SnowflakeQueryFromFile. Some users have been looping through .sql files with the ShellTask so this should help them.
The second fix is fixing the MS SQL Server execute Task. This was broken because the library can not take in kwargs. This fix is too hard to test I think.
Checklist
Edit - I edited the SnowflakeQueryFromFile to SnowflakeQueriesFromFile. It now takes in multiple SQL queries and returns a list of results of the queries.
This PR:
changes/
directory (if appropriate)docs/outline.toml
for API reference docs (if appropriate)