Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Environments #5072

Merged
merged 34 commits into from Oct 28, 2021
Merged

Remove support for Environments #5072

merged 34 commits into from Oct 28, 2021

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Oct 20, 2021

note this merges into a 1.0.0 release candidate branch instead of master

Summary

Removes environments which have been deprecated for several versions.

Changes

Cherry-picked the following commits from #4612

  • Remove deprecated FargateAgent
  • Remove deprecated prefect.environments module
  • Remove deprecated Flow.environment setting
  • Remove deprecated Flow.environment serializers
  • Add backwards compatibility for Flow.environment to flow diagnostics
  • Update flow tests to reflect removal
  • Update get_flow_image to use run_config instead of environment
  • Oh, there are two get_flow_image functions -- deprecate the old looking one
  • Remove environments from get_flow_run_command tests
  • Remove environment docker healthcheck tests
  • Remove environment serialization tests
  • Remove environment handling from Client.register
  • Remove environment handling from prefect build/register
  • Update _get_run_config to drop support for environments
  • Remove KubernetesAgent.generate_job_spec_from_environment
  • Remove LocalEnvironment from DockerAgent tests
  • Remove DockerAgent.network tests
  • Remove remaining DockerAgent environment tests
  • Drop some removed items from the API reference

Additional commits are quite granular and remove additional items from the documentation, fix tests, etc.

Importance

Removes an outdated configuration method. Replaced by RunConfig.

…king one

Also, remove environment handling from the newer one
Certainly there will be more but it is fickle locally
@zanieb zanieb changed the base branch from master to 1.0.0-rc1 October 21, 2021 21:42
@zanieb zanieb marked this pull request as ready for review October 21, 2021 21:42
@zanieb zanieb changed the title Remove Environment objects Remove support for Environments Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant