Include the map_index in the default create_flow_run idempotency key
#5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…key to support local flow run mapping
zanieb
changed the title
map_index in the default create_flow_run idempotency key to support local flow run mappingmap_index in the default create_flow_run idempotency key
Merged
zangell44
approved these changes
Mar 10, 2022
lance0805
pushed a commit
to hyl2015/prefect
that referenced
this pull request
Aug 2, 2022
…key (PrefectHQ#5443) * Include the `map_index` in the default `create_flow_run` idempotency key to support local flow run mapping * Fix logic if `task_run_id` is missing * Add tests * Add changes entry * Update docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task in local
flow.runcalls do not have unique task run ids when mapped. Sincecreate_flow_runuses thetask_run_idas the default idempotency key, mapped calls in local runs will only result in a single flow run. To resolve this, we can include themap_indexin the default idempotency key.Note that when running with a backend, each task run (mapped or not) has a distinct UUID.
Changes
Appends the
map_indexto the default idempotency key if present in the context.Extends test coverage for local runs, run names, and idempotency keys.
Importance
Mapping with
create_flow_runinflow.run()does not work as intended otherwise.Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)