Fix docker socket in docker agent on windows (docker in docker) #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the issue and fix! When you say
Does that mean you've tested it and it's working or you think it may work? |
|
Hey @madkinsz - the fix works, I have tested and confirmed. Possibly meaning one possibly fix. |
zanieb
approved these changes
Apr 13, 2022
Merged
lance0805
pushed a commit
to hyl2015/prefect
that referenced
this pull request
Aug 2, 2022
…ectHQ#5657) * Attempt to fix dind on windows * Cleanup, add changes/ * Run black Co-authored-by: Michael Adkins <michael@prefect.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A possibly fix for issues running docker tasks (docker-in-docker) on the docker agent on windows (see #5655)
Changes
Add special handling for the docker socket when running the docker agent in windows
Importance
It allows docker tasks to run on the docker agent in running on windows.
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)