Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support #5770

Merged
merged 6 commits into from May 10, 2022
Merged

Conversation

neumann-nico
Copy link
Contributor

Summary

This PR adds support for Python 3.10

I had a look at those Python 3.9 PRs:
#3441
#4896

Changes

Changes setup.py and CI to inlcude Python 3.10

Importance

Python 3.10 is the latest stable version of Python so it would be great to include it :)

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @neumann-nico! 🎉 🎉

@zanieb
Copy link
Contributor

zanieb commented May 10, 2022

Thank you so much for contributing! This looks good. It was missing one line to include the workflow in CircleCI, I pushed a commit to add it. Also, if you don't quote "3.10" in the GitHub Actions YAML it'll treat it as a decimal 3.1 and run tests on the wrong version.

Copy link
Contributor

@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs part lgtm! Thanks

@neumann-nico
Copy link
Contributor Author

Thank you for the correction!
It seems like the installation of typed-ast does not work on Windows with Python 3.10

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed mypy from the dev requirements as it's not needed for the Windows tests and is pinned in the type-checking CI job.

Thanks again!

@zanieb zanieb merged commit fbe6a23 into PrefectHQ:master May 10, 2022
@neumann-nico neumann-nico deleted the python-3.10-support branch May 13, 2022 21:40
@zanieb zanieb mentioned this pull request May 24, 2022
lance0805 pushed a commit to hyl2015/prefect that referenced this pull request Aug 2, 2022
* add Python 3.10 support

* add pr to changes

* include python 3.10 in docker.md

* Run 3.10 tests in CircleCI

* Quote Python versions on Windows

* Remove mypy from requirements

Co-authored-by: Michael Adkins <michael@prefect.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants