Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We thought we had identified all the weird DST issues with croniter, but a user recently stumbled across a new one. A simplified demo:
Which results in
To avoid this (and others potentially lurking), this adds a check to see if we're stuck in a date loop when evaluating cron. If so, we exit the loop by creating a new cron instance that begins yielding immediately AFTER the date question.
Changes
Fixes a bug where certain DST conditions put schedules into an infinite loop
Importance
Checklist
This PR:
changes/
directory (if appropriate)docs/outline.toml
for API reference docs (if appropriate)