Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move registering blocks to its own heading #6512

Merged
merged 3 commits into from Aug 22, 2022
Merged

Move registering blocks to its own heading #6512

merged 3 commits into from Aug 22, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 22, 2022 •
edited

Summary

It was hard to find how to add it to Cloud blocks, plus registering is not just for new block types, so I moved it to its own heading.

Steps Taken to QA Changes

Checklist

This pull request is:

  • A documentation / typographical error fix
    • No tests or issue needed
  • A short code fix
    • Please reference the related issue by including "closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a bug report issue
    • Please include tests. One-line fixes without tests will not be accepted unless it's related to the documentation only.
  • A new feature implementation
    • Please reference the related issue by including "closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a feature enhancement issue
    • Please include tests
    • Please make sure that your QA steps are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

@ahuang11
Move registering blocks to its own heading
1f017d8 
It's not just for new block types
@ahuang11
Copy link
Contributor Author

image

@ahuang11 ahuang11 marked this pull request as ready for review August 22, 2022 17:13
desertaxle
desertaxle reviewed Aug 22, 2022
View reviewed changes
docs/concepts/blocks.md Outdated Show resolved Hide resolved
ahuang11 and others added 2 commits August 22, 2022 10:14
@ahuang11
Move --file example under --module
3c5c483 
Since it's more used often
@ahuang11 @desertaxle
Update docs/concepts/blocks.md
904873f 
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
serinamarie
serinamarie approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@serinamarie serinamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for doing this.

tpdorsey
tpdorsey approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@tpdorsey tpdorsey added the docs label Aug 22, 2022
@ahuang11 ahuang11 merged commit d7ba087 into main Aug 22, 2022
@ahuang11 ahuang11 deleted the move_registering_blocks branch August 22, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdorsey tpdorsey tpdorsey approved these changes

@desertaxle desertaxle desertaxle approved these changes

@serinamarie serinamarie serinamarie approved these changes

@rpeden rpeden Awaiting requested review from rpeden

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahuang11 @tpdorsey @desertaxle @serinamarie