Use a singleton diagnostics logger for Client
#6832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each client "creates" a new logger which includes attaching handlers. Since Python loggers are singletons behind the scenes, this results in attaching duplicate handlers to the logger. Messages will then be duplicated per number of clients. Since task runs each have their own client, this can result in many log messages.
To resolve this, we define
logger
as a class variable instead of instance variable. The logger will be created once at import-time.Closes #6831