Fix Prefect Orion fails to start on Windows when there is a space in Prefect package's path #6880
Conversation
Prefect Orion fails to start on Windows when there is a space in Prefect package's path. PrefectHQ#6821
✅ Deploy Preview for prefect-orion ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @bansalkanav! Unfortunately the relative path won't work once the code is packaged, just during development. I think we need to look into "escaping" the spaces in the path instead or include |
|
Thanks for the feedback @madkinsz. Working on it. |
discdiver
changed the title
As suggested, wrapping the absolute path with `\"`
|
@madkinsz Requesting a review. As per your suggestion, updated the code. |
|
Hi @bansalkanav! It looks like you're a first-time contributor, so first, thanks for taking the time to contribute to Prefect! Before digging into the PR itself, I want to make sure that you've got your local development environment setup so that we're able to see the same thing when looking at proposed solutions. Our guide is located here: https://docs.prefect.io/contributing/overview/ Do you have a windows development environment that you are able to run the Prefect tests on, and are they running successfully? One other thing that is typically helpful is including a test for the bug that you are fixing. This helps us confirm that the root cause of the bug is understood, and that that the proposed code addresses it. |
|
Hi @peytonrunyan. Thanks for reverting back. Noted. I will set up the environment and let you know. Thanks for the guidance. |
|
Hi all! 👋 How are things looking for the PR? |
|
@discdiver replaced by #7224 — @peytonrunyan make sure to note superseded pull requests when opening. |
Issue - #6821
Summary
Bug Fix
str(prefect.__module_path__.parent)represents the absolute path. Prefect Orion fails to start in Windows OS if the directory path contains spaces."../.."represents relative path. This solves the problem.