New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for logging outside flow run #8394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
serinamarie
added
the
maintenance
Chores and other work not directly related to the product
label
Feb 3, 2023
zanieb
reviewed
Feb 3, 2023
zanieb
reviewed
Feb 3, 2023
zanieb
reviewed
Feb 3, 2023
This pull request is stale because it has been open 60 days with no activity. To keep this pull request open remove stale label or comment. |
@serinamarie with my suggested changes I do get a failure as expected by reverting the
|
zanieb
force-pushed
the
fix-test-logging-outside-flow-run
branch
from
April 4, 2023 17:18
2077fe7
to
ea2d871
Compare
I've rebased this onto |
desertaxle
approved these changes
Apr 4, 2023
asmundo
pushed a commit
to asmundo/prefect
that referenced
this pull request
May 11, 2023
Co-authored-by: Michael Adkins <michael@prefect.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds 4 new tests around the
PREFECT_LOGGING_ORION_WHEN_MISSING_FLOW
setting to ensure that:warn
does not raisewarn
does not raiseignore
does not raise or warnerror
does not warnExample
Intended to test cases like:
Checklist
<link to issue>
"fix
,feature
,enhancement