Add handling for statement timeouts to state validation #8425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
force-pushed
the
raise-timeouts-in-state-validation
branch
from
89d6d34
to
906ca0e
Compare
zanieb
commented
Feb 7, 2023
Comment on lines
+397
to
+399
| if self.run.state is None: | ||
| self.validated_state = None | ||
| return |
There was a problem hiding this comment.
This was previous behavior but avoids calling self.session.add(None) which throws an exception
|
Superseded by https://github.com/PrefectHQ/nebula/pull/3482 |
Getting a 404 upon clicking this link. |
|
@ccueto36 that's our internal repository — we're fixing this in Cloud but it does not need a fix in the open source. |
Got it. Thanks for the clarification. Looking forward to the fix. |
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8435
Database query timeouts are resulting in an ABORT response from the API:
Previously, these errors resulted in a 503 response allowing the client to retry. Since an aborted task run can crash the flow and these timeouts are happening frequently, customers are blocked by the lack of retry. It seems likely that this regression is due to a change from #8164 where error handling in state validation was fixed.
Here, we explicitly do not capture statement timeouts and instead reraise them. We should probably we doing cleanup instead of just raising an exception, but unfortunately this seems quite complicated and we should first attempt to achieve the previous behavior.
This pull request extends #8423 which adds baseline test coverage for this area.
Example
Discussion at https://prefecthq.slack.com/archives/C04F1PTMUCQ/p1675455197515479
User report at https://prefect-community.slack.com/archives/CL09KU1K7/p1675449149527989
Checklist
<link to issue>"fix,feature,enhancement