Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Docker storage to handle healthcheck issues #968

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Apr 23, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Uses self.flows.values() instead of keys() since the flow path was moved to a value. Pip installs from the current master branch of Prefect until a new version is released which contains all new storage and environment changes

Why is this PR important?

Avoids issues like:

Step 9/9 : RUN python /root/.prefect/healthcheck.py
 ---> Running in 203394a563b9
Beginning health check...
Traceback (most recent call last):
  File "/root/.prefect/healthcheck.py", line 5, in <module>
    with open(flow_file, 'rb') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'Test-Flow'

and

Step 9/9 : RUN python /root/.prefect/healthcheck.py
 ---> Running in 6b18ac805330
Beginning health check...
Traceback (most recent call last):
  File "/root/.prefect/healthcheck.py", line 6, in <module>
    flow = cloudpickle.load(f)
ModuleNotFoundError: No module named 'prefect.environments.execution'

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #968 into master will not change coverage.
The diff coverage is n/a.

@joshmeek joshmeek merged commit 0724b5e into master Apr 23, 2019
@joshmeek joshmeek deleted the touchups branch April 23, 2019 16:21
zanieb added a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants