Simplify LoopService.loop_seconds handling and add debug mode to speedup tests
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zanieb
commented
Apr 12, 2021
Comment on lines
+35
to
+36
| @property | ||
| def loop_seconds(self): |
There was a problem hiding this comment.
I noticed some code in the Cloud batch writer that also implements this property which made me feel retaining the _default suffix on loop_seconds was the easiest way to avoid naming collisions. I'll probably rewrite those to call super(). in their default cases.
zanieb
commented
Apr 12, 2021
Comment on lines
-19
to
-21
| # if set, and no `loop_seconds` is provided, the service will attempt to load | ||
| # `loop_seconds` from this config key | ||
| loop_seconds_config_key = None |
There was a problem hiding this comment.
This feature is unused and is being removed for simplification
zanieb
commented
Apr 12, 2021
| # shutdown flag for gracefully exiting the infinite loop | ||
| is_running = True | ||
|
|
||
| def __init__(self, loop_seconds: Union[float, int] = None): |
There was a problem hiding this comment.
Passing loop seconds to __init__ is unused and is being removed for simplification.
jlowin
previously approved these changes
Apr 13, 2021
The tests that we care about speeding up run the services outside pytest :D
|
@jlowin I realized that we start services separately from tests in the integration/service test CI steps so I've switched to a different environment variable than the pytest one. |
jlowin
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
loop_secondsloading__init__``loop_secondspassingloop_secondsloop_seconds_debugthat is set during tests by defaultChecklist
This PR:
changes/directory (if appropriate)