Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo post-start to wait for graphql service #41

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

joshmeek
Copy link
Contributor

@joshmeek joshmeek commented Aug 12, 2020

Thanks for contributing to Prefect Server!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • adds a changelog entry to the changes/ directory (if appropriate)

Note that your PR will not be reviewed unless these two boxes are checked.

What does this PR change?

Updates Apollo's post-start.sh to properly wait for the graphql service to be accessible.

Why is this PR important?

The previous iteration of this did not properly function because we aren't currently providing a PREFECT_SERVER_VERSION to the image and kill 1 wasn't exiting either.

@codecov-commenter
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@cicdw cicdw merged commit 8f3c5ef into master Aug 13, 2020
@cicdw cicdw deleted the apollo_entrypoint branch August 13, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants