Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Setting ECS RunConfig Env Variables in UI Casts Strings to Integer #979

Closed
1 task done
kvnkho opened this issue Aug 4, 2021 · 0 comments · Fixed by #1095
Closed
1 task done

BUG: Setting ECS RunConfig Env Variables in UI Casts Strings to Integer #979

kvnkho opened this issue Aug 4, 2021 · 0 comments · Fixed by #1095
Assignees
Labels
bug Something isn't working Run Page Related to the UI Run Page
Milestone

Comments

@kvnkho
Copy link
Contributor

kvnkho commented Aug 4, 2021

Bug Description

When using the UI, if you go to Run -> Advanced Configuration -> ECSRun -> Environment Variables, and you set a numeric string, it gets coerced to an integer. This is a problem because ECS itself does not take integers as environment variables and only takes strings. Thus, the Flow will error out and not even run.

There is something weird though because the coercion only happens when using the JSON editor. If you fill in the blanks, it seems to respect the data type.

Steps To Reproduce

  1. Register any flow that uses ECSRun. Just make sure it works, it can be anything.
  2. Go to Run for the Flow, and put an env variable "test" with the value "100".
  3. Click run and this will error out saying that 100 is not an acceptable env variable for ECS.

Browsers Tested:

  • Chrome

Notes

Images attached as guidance of the error, and the JSON editor.

Image 1 - section of the UI where Run is hit
Image 2- JSON editor and value
Image 3 - Error seen

Screen Shot 2021-08-04 at 4 11 58 PM

Screen Shot 2021-08-04 at 4 12 21 PM

Screen Shot 2021-08-04 at 4 12 45 PM

@kvnkho kvnkho added the bug Something isn't working label Aug 4, 2021
@zhen0 zhen0 added the Run Page Related to the UI Run Page label Sep 28, 2021
@zhen0 zhen0 added this to the Run Page milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Run Page Related to the UI Run Page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants