Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Enable deletion of agent configs in automations #1153

Merged
merged 20 commits into from
Feb 16, 2022
Merged

Feature: Enable deletion of agent configs in automations #1153

merged 20 commits into from
Feb 16, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Dec 9, 2021 •
edited

Describe this PR

Begins to add suggestions from #1113

@zhen0 zhen0 changed the title Agent config Feature: Enable deletion of agent configs in automations Dec 9, 2021
@zhen0 zhen0 marked this pull request as ready for review December 9, 2021 18:47
@ThatGalNatalie
Copy link
Contributor

After creating an agent config and then deleting it, the next button was still clickable for me and the config name was still highlighted. I expected the next button to be disabled and the config name to be changed back to "this config"

agent.mov

@zhen0 zhen0 marked this pull request as draft December 14, 2021 11:59
@zhen0 zhen0 marked this pull request as ready for review December 23, 2021 04:16
@stackoverfloweth
Copy link
Contributor

pages/Dashboard/Automations/AddAutomationCard.vue is a huge file. I think it would be good to move your changes out into a separate file. If it's not too out of scope, I'm sure there are other components that could be picked out without a huge refactor

@zhen0 zhen0 marked this pull request as draft December 27, 2021 20:15
@zhen0 zhen0 marked this pull request as ready for review January 11, 2022 16:28
stackoverfloweth
stackoverfloweth approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@stackoverfloweth stackoverfloweth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 👌

@zhen0 zhen0 merged commit ca8565a into master Feb 16, 2022
@zhen0 zhen0 deleted the agent-config branch February 16, 2022 17:45
@zhen0 zhen0 mentioned this pull request Feb 17, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackoverfloweth stackoverfloweth stackoverfloweth approved these changes

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin jlowin is a code owner

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhen0 @ThatGalNatalie @stackoverfloweth @cicdw