Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October package updates #317

Merged
merged 9 commits into from Oct 12, 2020
Merged

October package updates #317

merged 9 commits into from Oct 12, 2020

Conversation

znicholasbrown
Copy link
Contributor

@znicholasbrown znicholasbrown commented Oct 12, 2020

October package updates

Resolutions:

Closes: #316

Closes: #315

Closes: #314

Closes: #313

Closes: #256

Closes: #239

Closes: #225

Closes: #224

Closes: #221

Closes: #206

Closes: #204

The most significant change to the codebase with these updates is the move from v-slot attributes to #-style syntax. Moving forward, v-slot will no longer be accepted by the linter; all existing instances have been updated. For default slots where v-slot didn't have a name attribute, #default can be used instead.

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM @znicholasbrown

@znicholasbrown znicholasbrown merged commit 5caebd7 into master Oct 12, 2020
@znicholasbrown znicholasbrown deleted the package-updates branch October 12, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants