Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch task runs for mark as dialog #411

Merged
merged 18 commits into from Nov 11, 2020
Merged

fetch task runs for mark as dialog #411

merged 18 commits into from Nov 11, 2020

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Nov 9, 2020 •
edited

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • Fixes a bug on the set state button on the flow run page where the option to include task run states was not working.

znicholasbrown
znicholasbrown previously requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely fail for large mapped pipelines - I'm not sure how we want to address that UX. Maybe we should filter out task runs with > -1 map index? Other than that, just one issue to fix.

src/mixins/changeStateMixin.js Outdated Show resolved Hide resolved
@zhen0
Copy link
Member Author

zhen0 commented Nov 10, 2020

Actually - not ready for review - just seen something else that needs updating...

@zhen0 zhen0 marked this pull request as draft November 10, 2020 22:55
@zhen0 zhen0 marked this pull request as ready for review November 11, 2020 04:23
znicholasbrown
znicholasbrown previously requested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great @zhen0, just 1 suggestion to clean up the task run ids query file.

src/graphql/FlowRun/task-run-ids.gql Outdated Show resolved Hide resolved
@zhen0 @znicholasbrown
Update src/graphql/FlowRun/task-run-ids.gql
994b1e9 
Co-authored-by: Nicholas Brown <nicholas@prefect.io>
@zhen0
Copy link
Member Author

zhen0 commented Nov 11, 2020

Thanks @znicholasbrown - made that clean up. (This whole feature needs a re-factor at some point!)

@znicholasbrown znicholasbrown merged commit d1120ac into master Nov 11, 2020
@znicholasbrown znicholasbrown deleted the mark-as branch November 11, 2020 20:22
@znicholasbrown znicholasbrown mentioned this pull request Nov 11, 2020
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@jlowin jlowin Awaiting requested review from jlowin jlowin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhen0 @znicholasbrown