Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up task failures tile #45

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Speed up task failures tile #45

merged 1 commit into from
Aug 4, 2020

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Aug 3, 2020

This PR adjusts the task failures tile to be more performant.

Previously, the tile did the following:

  • load all tasks that have failed task runs
  • for each task, query for its flow
  • for each task, query for all task runs and count the task runs (in the client)

Following the pattern in the failed flows tile, this PR removes the count, which dramatically simplifies the pattern and lets us avoid two complex db calls entirely.

@znicholasbrown
Copy link
Contributor

I'm not able to load this tile with the 7 day filter selected, the DB still seems to be timing out. 1 option is to remove that filter option entirely, but that's not really ideal

@jlowin
Copy link
Member Author

jlowin commented Aug 4, 2020

I'll look into that

@jlowin
Copy link
Member Author

jlowin commented Aug 4, 2020

Appears to be ok, it was likely some unrelated pressure

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We looked at this last night, the timeouts seem to be unrelated but will keep an eye on it.

@znicholasbrown znicholasbrown merged commit 97bee9c into master Aug 4, 2020
@znicholasbrown znicholasbrown deleted the task-failures-tile branch August 4, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants