Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial on hyperparameter search for VAECF #290

Merged
merged 5 commits into from Jan 14, 2020

Conversation

saghiles
Copy link
Member

Description

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

tutorials/param_search_vaecf.ipynb Outdated Show resolved Hide resolved
tutorials/param_search_vaecf.ipynb Outdated Show resolved Hide resolved
tutorials/param_search_vaecf.ipynb Outdated Show resolved Hide resolved
@tqtg
Copy link
Member

tqtg commented Jan 13, 2020

I think we should mention that the best params are determined by the validation set. The validation results can be shown in addition to the test results.

@saghiles
Copy link
Member Author

In the subsection run an experiment, it is mentioned that the best results are select based on the validation set. One question: are the validation results displayed by default?

@tqtg
Copy link
Member

tqtg commented Jan 13, 2020

In the subsection run an experiment, it is mentioned that the best results are select based on the validation set. One question: are the validation results displayed by default?

Yes, the validation results will be displayed by default if the validation set is available.

@tqtg
Copy link
Member

tqtg commented Jan 13, 2020

@saghiles I'm good with this PR. Feel free to merge it if you have no further changes.

@saghiles saghiles merged commit ca356d0 into PreferredAI:master Jan 14, 2020
@saghiles saghiles deleted the param_search_vae branch December 28, 2020 04:20
tqtg pushed a commit to amirj/cornac that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants