Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail build scripts if any command fails #14

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Fail build scripts if any command fails #14

merged 3 commits into from
Apr 24, 2019

Conversation

bartlettc22
Copy link
Collaborator

Builds were succeeding even if the app didn't compile - I believe this will fix that

lwahlmeier
lwahlmeier reviewed Apr 24, 2019
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
lwahlmeier
lwahlmeier approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@lwahlmeier lwahlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, idk if we need the pipefail in the comment I added, leave it up to you.

@bartlettc22 bartlettc22 merged commit 983069b into master Apr 24, 2019
@bartlettc22 bartlettc22 deleted the buildfail branch April 24, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwahlmeier lwahlmeier lwahlmeier approved these changes

@thorix thorix Awaiting requested review from thorix thorix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlettc22 @lwahlmeier