fixed how Errors are handled #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwahlmeier
reviewed
May 17, 2019
pkg/vault/error.go
Outdated
| MessageParts []string | ||
| OriginalError error | ||
| } | ||
|
|
||
| // Error is custom error interface with one method that will block other functions | ||
| // from using this Error. This is not interchangeable with the standard error. | ||
| type Error interface { |
There was a problem hiding this comment.
Personally I would change this error name to, could possibly get away with keeping CustomVaultError private customVaultError and then only using the interface everywhere
lwahlmeier
reviewed
May 17, 2019
lwahlmeier
reviewed
May 17, 2019
lwahlmeier
reviewed
May 17, 2019
pkg/vault/token.go
Outdated
| @@ -11,7 +11,7 @@ func (v *Vault) GetCurrentTokenTTL() (time.Duration, error) { | |||
| // Get the token info from Vault | |||
| secret, err := v.client.Auth().Token().LookupSelf() | |||
| if err != nil { | |||
| return 0, err | |||
| return 0, v.parseError(err) | |||
There was a problem hiding this comment.
This function should be returning Error not error
bartlettc22
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors where double printing part of the message. We found that parseError was being called two times creating this output:
2019-05-17 10:54:03.870426 [ FATAL ] Vault Error: Vault Error: Get...