updated stim.Config options #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorix
reviewed
Sep 17, 2019
| @@ -223,6 +223,8 @@ gopkg.in/alecthomas/kingpin.v3-unstable | |||
| gopkg.in/inf.v0 | |||
| # gopkg.in/yaml.v2 v2.2.2 | |||
| gopkg.in/yaml.v2 | |||
There was a problem hiding this comment.
You still need this version two parts?
There was a problem hiding this comment.
I didnt make that file so I dont know, it could be any libs or other dependencies pulling it in, thats made by go mod init/vendor
thorix
reviewed
Sep 17, 2019
| return err | ||
| } | ||
| cm := config[keys[0]].(map[interface{}]interface{}) | ||
| //This is super gross, not sure of a better way to deal with this |
There was a problem hiding this comment.
Would agree, but I don't know how to do it better.
thorix
reviewed
Sep 17, 2019
| func init() { | ||
| home, err := homedir.Dir() | ||
| if err != nil { | ||
| defaultStimConfigFilePath = filepath.Join(os.TempDir(), ".stim", "config.yaml") |
There was a problem hiding this comment.
Why would this happen? When would this code run and there isn't a home dir? os.TempDir()
There was a problem hiding this comment.
Yeah, say a badly setup build machine or something like that with no home env, we need to do something thats the best idea I had.
thorix
approved these changes
Sep 18, 2019
bartlettc22
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did updates to the stim.Config* calls and how we deal with the config file.