Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added deploy config for removing manual ALL option and forcing manual… #38

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

lwahlmeier
Copy link
Member

added deploy config for removing manual ALL option and forcing manual confirmation, fixed bug in PromptBool and exit if you ctrt+C during deploy selection

fixes #37

… confermation, fixed bug in PromptBool and exit if you ctrt+C during deploy selection
Copy link
Collaborator

@thorix thorix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only question I had was if one of the options should be the default to help? newer users.

@lwahlmeier
Copy link
Member Author

Looks good. The only question I had was if one of the options should be the default to help? newer users.

Maybe, I didnt want to change the current defaults as that changes our current scripts, but we can later

@lwahlmeier lwahlmeier merged commit a1784c7 into master Nov 29, 2019
@lwahlmeier lwahlmeier deleted the DeployPrompts branch February 21, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ctrl+c on environment prompt mangles log and proceeds
2 participants