Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new deploy container and improved build process #44

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Added new deploy container and improved build process #44

merged 3 commits into from
Feb 4, 2020

Conversation

bartlettc22
Copy link
Collaborator

  • Added new "deploy" container
  • Updated tagging strategy (see changelog)
  • Removed "sleep" from build process: now uses volume mounts instead

thorix
thorix approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@thorix thorix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran into this problem yesterday with the need for bash and jq

@bartlettc22 bartlettc22 merged commit 638475b into master Feb 4, 2020
@bartlettc22 bartlettc22 deleted the deploy-container branch February 4, 2020 23:37
@bartlettc22 bartlettc22 mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwahlmeier lwahlmeier lwahlmeier approved these changes

@thorix thorix thorix approved these changes

@rayjanoka rayjanoka Awaiting requested review from rayjanoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlettc22 @lwahlmeier @thorix