Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the AWS federation username to use the vault-username #45

Merged
merged 4 commits into from
Feb 8, 2020

Conversation

rayjanoka
Copy link
Contributor

@thorix made me do it!

Copy link
Member

@lwahlmeier lwahlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks fine, I am a bit concered about the number of go vendor packages that where added/removed for no code change.
I ran a go mod tidy and it cleans up most the added modules.

@rayjanoka
Copy link
Contributor Author

The code change looks fine, I am a bit concered about the number of go vendor packages that where added/removed for no code change.
I ran a go mod tidy and it cleans up most the added modules.

nice1

@thorix
Copy link
Collaborator

thorix commented Feb 8, 2020

We talked about the change added there at the end. This will enable stim to source/validate the username from Vault. It seemed just trusting the set username from the stim config was maybe not the best. Also, maybe better code practice if the username didn't exist to go to the source. This is less of a security feature since the user could always take the Vault provided IAM creds and just generate their own STS AWS console access. The provided username is collected from the user and should never be trusted anyways...

@thorix thorix merged commit afdf00e into master Feb 8, 2020
@thorix thorix deleted the vault-user-for-federation-login branch February 8, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants