Adding timeout vault option and better error handling #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bartlettc22
commented
Feb 26, 2019
bartlettc22
commented
- Adding config value vault-timeout (default 15 seconds)
- Adding better error handling for Vault operations
lwahlmeier
reviewed
Mar 6, 2019
| ) | ||
|
|
||
| // Error is the custom error type for this package | ||
| type Error struct { |
There was a problem hiding this comment.
Feel like this should be named something more specific, to easy to confuse error and Error and mismatch them. I would say something like StimError, or even StimVaultError
lwahlmeier
reviewed
Mar 6, 2019
| @@ -11,17 +10,17 @@ func (v *Vault) GetSecretKey(path string, key string) (string, error) { | |||
|
|
|||
| secret, err := v.client.Logical().Read(path) | |||
| if err != nil { | |||
| return "", err | |||
| return "", v.parseError(err) | |||
There was a problem hiding this comment.
I would assume you want to return Error (or whatever we might change it too) so if someone wants to handle it a different way farther down (say another stimpack calling it) they would not have to see if its castable.
lwahlmeier
reviewed
Mar 6, 2019
| MessageParts []string | ||
| OriginalError error | ||
| } | ||
|
|
There was a problem hiding this comment.
Might want to add a String() func to this so if someone outputs it in a log things look correct. https://tour.golang.org/methods/17
|
All in all looks good, added a few comments you might want to look through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.