Adding tab completion functionality for Bash and Zsh #56
Conversation
|
@IdlePhysicist dont worry about the build, we apparently where using |
| `, | ||
| ValidArgs: []string{"bash", "zsh"}, | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| if err := c.stim.GetCompletion(args[0]); err != nil { |
There was a problem hiding this comment.
need to check that len(args) > 0 before hitting this line. stim completion causes a stack trace w/o useful messages. There might be a way to have cobra/viper do that for you.
There was a problem hiding this comment.
I did try to do the arg validation a more extravagant way, but I think this will suffice. It will fail gracefully & exit for len(args) != 1 and in the switch statement in stim/completion.go I am logging out "unknown shells".
|
Fixed master build, get that merged in so we can get the build to pass, also left one comment we should probably take care of, but then I think it looks good to merge. |
To fix build pipeline py2 failure.
Pretty small addition to the code base but I felt it was a worthy one since
cobrahas completion generation built in.Comments welcome, and rejection too.