Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow all config options to also be envVars using subpaths #70

Merged
merged 2 commits into from
Jan 8, 2021
Merged

allow all config options to also be envVars using subpaths #70

merged 2 commits into from
Jan 8, 2021

Conversation

lwahlmeier
Copy link
Member

allow all config options to also be envVars including subpaths with a '.' then get translated to - in viper config

medavisjr
medavisjr approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@medavisjr medavisjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I will test this when it's merged and probably add a doc update for how the env var naming works and can be used

@lwahlmeier lwahlmeier merged commit 9981752 into master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medavisjr medavisjr medavisjr approved these changes

@bartlettc22 bartlettc22 Awaiting requested review from bartlettc22 bartlettc22 is a code owner

@thorix thorix Awaiting requested review from thorix thorix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lwahlmeier @medavisjr