Stimlog #9
Merged
Stimlog #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlettc22
requested changes
Apr 11, 2019
pkg/prometheus/prometheus.go
Outdated
| Logger | ||
| } | ||
|
|
||
| type Logger interface { |
There was a problem hiding this comment.
I'm not sure I agree with removing the interface and forcing people using this package to use "github.com/readytalk/stim/pkg/stimlog". The whole idea was to allow a consumer of this package to pass in any logger they wanted as long as it has the Debug and Info methods.
There was a problem hiding this comment.
I dont completely disagree, but its a little silly to require Stim, which has its logger, then not use its logger. Right now because of that there is no way these packages can be independent from stim.
Actually, let me put out the changes I have around redoing stimpacks to make them independent from stim, just didnt want to do it all in one shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commonizes logger to StimLogger. There are some features I want to add to the logger and will probably just use that over logurs in the end.