Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nominate This bookmarklet #1093

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

r-a-y
Copy link
Contributor

@r-a-y r-a-y commented Sep 28, 2021

Hi,

Our users reported that the Nominate This bookmarklet was no longer working. Tested on WordPress 5.8.0.

In this PR, I've updated the bookmarklet code to better mirror the Press This bookmarklet code from https://github.com/WordPress/press-this/blob/9ca88faabbf9e7eb6595a6b5da3b9120becf2ab6/press-this-plugin.php#L144-L150.

I can confirm that the bookmarklet now works.

@r-a-y r-a-y changed the base branch from master to 5.2.x September 28, 2021 21:03
@boonebgorges
Copy link
Contributor

Thanks for the PR!

@boonebgorges boonebgorges modified the milestones: 5.3, 5.2.8 Sep 30, 2021
@boonebgorges boonebgorges merged commit 41e8a6b into PressForward:5.2.x Sep 30, 2021
@r-a-y r-a-y deleted the fix/bookmarklet branch September 30, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants