Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradients for euler 2d and swe 2d #164

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Conversation

fnrizzi
Copy link
Member

@fnrizzi fnrizzi commented Sep 17, 2023

  • including the header for euler2d and swe2d automatically includes the gradients

  • gradients are NOT computed automatically by the problem/app object for several reasons:

    • the gradient just needs a mesh object and field/function on it, so it is fully orthogonal to what the field is/comes from. Indeed, an app object never owns the state nor the mesh.
    • decoupling the two makes things more flexible for how and when the gradients are calculated
    • decoupling also allows to contruct the gradient evaluator independently of the app object
  • test added only for Euler2d for now

  • drive-by changes to fix template for gradient class and test

@fnrizzi fnrizzi merged commit 453c224 into develop Sep 18, 2023
4 checks passed
@fnrizzi fnrizzi deleted the gradients_for_euler_swe_2d branch March 18, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant