Merge pull request #5397 from Quetzacoalt91/module-repository-check-c…

…lass

// CORE : Move require of module class to handle more potential issues

src/Adapter/Module/ModuleDataProvider.php

@@ -91,7 +91,8 @@ public function isInstalled($name)
     public function isModuleMainClassValid($name)
     {
         $file_path = _PS_MODULE_DIR_.$name.'/'.$name.'.php';
-        if (!file_exists($file_path)) {
+        // Check if file exists (slightly faster than file_exists)
+        if (!(int)@filemtime($file_path)) {
             return false;
         }
 
@@ -112,7 +113,19 @@ public function isModuleMainClassValid($name)
         // But namespace and use statements need to be removed
         $content = preg_replace('/\n[\s\t]*?use\s.*?;/', '', $file);
         $content = preg_replace('/\n[\s\t]*?namespace\s.*?;/', '', $content);
-        return (eval('if (false){	'.$content.' }') !== false);
+        if (eval('if (false){	'.$content.' }') === false) {
+            return false;
+        }
+
+        // Even if we do not detect any parse error in the file, we may have issues
+        // when trying to load the file. (i.e with additionnal require_once)
+        try {
+            require_once $file_path;
+        } catch (\Exception $e) {
+            return false;
+        }
+
+        return true;
     }
 
     /**