Update classes/PaymentModule.php

Change strcmp for strict inequality operator for amount string comparison Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
PrestaShop · Dec 9, 2021 · d7755bd · d7755bd
1 parent d1bfdf2
commit d7755bd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/classes/PaymentModule.php b/classes/PaymentModule.php
@@ -321,7 +321,7 @@ public function validateOrder(
             // if ($order->total_paid != $order->total_paid_real)
             // We use number_format to convert the numbers to strings and strcmp to compare them to avoid auto reconversions to numbers in PHP < 8.0
             $comp_precision = Context::getContext()->getComputingPrecision();
-            if ($order_status->logable && (strcmp(number_format($cart_total_paid, $comp_precision), number_format($amount_paid, $comp_precision)) != 0)) {
+            if ($order_status->logable && (number_format($cart_total_paid, $comp_precision) !== number_format($amount_paid, $comp_precision))) {
                 PrestaShopLogger::addLog('PaymentModule::validateOrder - Total paid amount does not match cart total', 3, null, 'Cart', (int) $id_cart, true);
                 $id_order_state = Configuration::get('PS_OS_ERROR');
             }