Skip to content

Commit

Permalink
Merge pull request #34253 from boubkerbribri/revert/chrome-beta
Browse files Browse the repository at this point in the history
Functional Tests: Revert chrome-beta and use chromium
  • Loading branch information
boubkerbribri committed Oct 12, 2023
2 parents c7740b7 + c74b985 commit f6eeafa
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 25 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/cron_nightly_tests_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,9 @@ jobs:

- name: Install browsers
working-directory: ${{ inputs.TESTS_DIR }}
if: ${{ env.GH_BRANCH == '8.0.x' || env.GH_BRANCH == '8.1.x' }}
if: env.GH_BRANCH != '1.7.8.x'
run: npx playwright install --with-deps

- name: Install browsers
working-directory: ${{ inputs.TESTS_DIR }}
if: env.GH_BRANCH == 'develop'
run: npx playwright install chrome-beta

# Run tests (if error, we continue for uploading report)
- name: Run tests
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sanity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

- name: Install browsers
working-directory: ./tests/UI
run: npx playwright install chrome-beta
run: npx playwright install --with-deps

- name: Run tests
run: npm run test:sanity:fast-fail
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui_tests_code_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
run: npm ci

- name: Install browsers
run: npx playwright install chrome-beta
run: npx playwright install --with-deps

- name: Generate mocha reports with failed steps
run: GENERATE_FAILED_STEPS=true npm run test:all
Expand Down
30 changes: 15 additions & 15 deletions tests/UI/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/UI/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"mocha": "^10.2.0",
"mochawesome": "^7.1.3",
"pdfjs-dist": "^3.4.120",
"playwright": "^1.38.1",
"playwright": "^1.39.0",
"xpath-ts": "^1.3.13"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion tests/UI/utils/globals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ global.BROWSER = {
headless: process.env.HEADLESS ? JSON.parse(process.env.HEADLESS) : true,
timeout: 0,
slowMo: process.env.SLOW_MO ? parseInt(process.env.SLOW_MO, 10) : 5,
channel: 'chrome-beta',
},
interceptErrors: process.env.INTERCEPT_ERRORS ? JSON.parse(process.env.INTERCEPT_ERRORS) : false,
};
Expand Down

0 comments on commit f6eeafa

Please sign in to comment.