Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleColumn option name changed between 1.7.5 and 1.7.6 #13544

Closed
matks opened this issue Apr 23, 2019 · 2 comments
Closed

ToggleColumn option name changed between 1.7.5 and 1.7.6 #13544

matks opened this issue Apr 23, 2019 · 2 comments
Assignees
@matks
Labels
1.7.6.x Branch Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression
Projects
PrestaShop 1.7.6
Milestone
1.7.6.0

Comments

@matks
Copy link
Contributor

matks commented Apr 23, 2019 •
edited

Spotted by @Payalba

Option name has been changed in #10160 as you can see in dba537c#diff-d4a0158121accdf8e50d139ae4a9e7b1

It was route_param_id and it is now route_param_name
@matks matks changed the title Breaking change on ToggleColumn options between 1.7.5 and 1.7.6 Option nale changed for ToggleColumn between 1.7.5 and 1.7.6 Apr 23, 2019
@matks matks changed the title Option nale changed for ToggleColumn between 1.7.5 and 1.7.6 ToggleColumn option name changed between 1.7.5 and 1.7.6 Apr 23, 2019
@matks matks mentioned this issue Apr 23, 2019
Closed
@khouloudbelguith khouloudbelguith added 1.7.6.x Branch Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Ready Status: Issue is ready to be worked on labels Apr 24, 2019
@khouloudbelguith khouloudbelguith added this to Backlog in PrestaShop 1.7.6 via automation Apr 24, 2019
@colinegin colinegin moved this from Backlog to To do in PrestaShop 1.7.6 May 22, 2019
@matks
Copy link
Contributor Author

matks commented May 30, 2019

Solution: allow both options to be used (so old name is an alias) although old name is deprecated

@sarjon sarjon mentioned this issue May 30, 2019
Merged
@matks
Copy link
Contributor Author

matks commented Jun 3, 2019

Fixed by #14027

@matks matks closed this as completed Jun 3, 2019
PrestaShop 1.7.6 automation moved this from To do to Done Jun 3, 2019
@marionf marionf added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Sep 18, 2019
@marionf marionf added this to the 1.7.6.0 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matks matks

Labels
1.7.6.x Branch Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression
Projects
No open projects
PrestaShop 1.7.6
  
Done
Milestone
1.7.6.0
Development

No branches or pull requests
3 participants
@matks @marionf @khouloudbelguith