Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleColumn wrong parameter #258

Closed
Payalba opened this issue Apr 19, 2019 · 4 comments
Closed

ToggleColumn wrong parameter #258

Payalba opened this issue Apr 19, 2019 · 4 comments

Comments

@Payalba
Copy link

Payalba commented Apr 19, 2019

Hi,

I think the name of the option property 'route_param_name' in ToggleComumn Type (https://devdocs.prestashop.com/1.7/development/components/grid/columns-reference/toggle/) is wrong

The good options property is 'route_param_id'

Regards,

PYT
@matks
Copy link
Contributor

matks commented Apr 23, 2019

Hi @Payalba according to the source file, it really is route_param_name:
https://github.com/PrestaShop/PrestaShop/blob/develop/src/Core/Grid/Column/Type/Common/ToggleColumn.php

@Payalba
Copy link
Author

Payalba commented Apr 23, 2019

The name changed between 1.7.5 and 1.7.6 ?
But the doc for the 1.7.5 say "route_param_name" and it is route_param_id in the 1.7.5 version.

@matks
Copy link
Contributor

matks commented Apr 23, 2019

You are right. Congratulations you spotted a real issue 😉

I opened PrestaShop/PrestaShop#13544 to solve it, then we can fix the doc accordingly

@matks
Copy link
Contributor

matks commented Jun 3, 2019

Fixed by PrestaShop/PrestaShop#14027

@matks matks closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matks @Payalba