Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid presenter hook doesn't respects the documentation #13579

Closed
mickaelandrieu opened this issue Apr 26, 2019 · 3 comments · Fixed by #13609
Closed

Grid presenter hook doesn't respects the documentation #13579

mickaelandrieu opened this issue Apr 26, 2019 · 3 comments · Fixed by #13609
Labels
Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification

Comments

@mickaelandrieu
Copy link
Contributor

Describe the bug
While defining a hook to customize the Grid presentation, the dispatched hook is wrong.

It's not formatted like the other ones, making the use of this hook impossible while using lowercased grid identifiers.

See https://github.com/PrestaShop/PrestaShop/blob/develop/src/Core/Grid/Presenter/GridPresenter.php#L96 while for others one the Grid identifier is formatted https://github.com/PrestaShop/PrestaShop/blob/develop/src/Core/Grid/GridFactory.php#L92.

Can we fix this for 1.7.6?

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots
If applicable, add screenshots or screenrecords to help explain your problem.

Additionnal information
PrestaShop version: N/A
PHP version: N/A
@khouloudbelguith
Copy link
Contributor

ping @PrestaShop/prestashop-core-developers

@khouloudbelguith khouloudbelguith added the Waiting for dev Status: action required, waiting for tech feedback label Apr 26, 2019
@mickaelandrieu mickaelandrieu mentioned this issue Apr 26, 2019
Merged
@mickaelandrieu
Copy link
Contributor Author

Hi @khouloudbelguith, I just fixed the issue 👍

@khouloudbelguith khouloudbelguith added Bug Type: Bug Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification and removed Waiting for dev Status: action required, waiting for tech feedback labels Apr 26, 2019
@khouloudbelguith
Copy link
Contributor

Hi @mickaelandrieu,

Great!
Good work 😄

@eternoendless eternoendless added Major Severity: major bug > https://build.prestashop.com/news/severity-classification and removed Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification labels Apr 26, 2019
@eternoendless eternoendless changed the title [Critical] Grid presenter hook doesn't respects the documentation Grid presenter hook doesn't respects the documentation Apr 26, 2019
@mickaelandrieu mickaelandrieu mentioned this issue Apr 29, 2019
Merged
@eternoendless eternoendless added the Fixed Resolution: issue closed because fixed label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dispatched hook on the Grid presenter: action<GridDefinitionId>GridFilterFormModifier
3 participants
@eternoendless @mickaelandrieu @khouloudbelguith