Fixed dispatched hook on the Grid presenter #13580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolelievre
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
I'm okay with this, however are you sure about the target branch? 175?
As we are about to publish a release for 175 this is the occasion
This could represent a BC break, but as far as we know the only existing grids are our own (I don't think some modules use this hook yet) and should use camel case ids for now
Also the PrettyCI check fails, we might need to ignore it @eternoendless ?
eternoendless
approved these changes
Apr 29, 2019
|
Tested by @mickaelandrieu, if something breaks down it's his fault 😛 |
|
Thank you @mickaelandrieu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is