Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faceted search bad currency format - thousands separator #14657

Closed
Tracked by #9684
Hlavtox opened this issue Jul 15, 2019 · 14 comments
Closed
Tracked by #9684

Faceted search bad currency format - thousands separator #14657

Hlavtox opened this issue Jul 15, 2019 · 14 comments
Assignees
@PierreRambaud
Labels
1.7.5.2 Affects versions 1.7.6.0 Affects versions Bug Type: Bug CLDR Faceted search Module: ps_facetedsearch Fixed Resolution: issue closed because fixed FO Category: Front Office Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression
Projects
PrestaShop 1.7.6
Milestone
1.7.6.1

Comments

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 15, 2019 •
edited

Describe the bug
Price amount in faceted price filter has a different format then the store. It contains comma instead of space as a THOUSAND SEPARATOR.

Language: Czech
Currency: Kč (CZK)

Store: 1 000 Kč
Filter: 1,000 Kč

Screenshots
currency

Note
Achieved zero decimals by changing precision from 2 to 0 in ps_currency. No files related to this are modified.

Additional information
PrestaShop version: 1.7.6
@mariem-abid
Copy link

Hi @Hlavtox,

Which country is selected for the installation of your shop?

@mariem-abid mariem-abid added Bug Type: Bug Faceted search Module: ps_facetedsearch NMI Status: issue needs more information 1.7.6.0 Affects versions labels Jul 15, 2019
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 15, 2019

@mariem-abid Czech Republic

@mariem-abid
Copy link

@Hlavtox, I did not manage to reproduce the issue with PS:1.7.6.0
I attached a video record
https://drive.google.com/file/d/1p8p4etxnYsx6RN9N3MAn8WQPpgc9nYRg/view

Thanks for check and feedback.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 15, 2019

@mariem-abid I am talking about the thousands separator. Make a product with a price over 1000,00 and you will see the error

@ghost
Copy link

ghost commented Jul 15, 2019

Hello,
I have a pretty similar issue, I am getting 6 decimals, instead of just 2.

@Hlavtox Hlavtox changed the title Faceted search bad currency format Faceted search bad currency format - thousands separator Jul 15, 2019
@m3ss3ng3rAC
Copy link

Hi,
same issue here: 6 decimals instead of 2. I've been digging for hours in the php and js files without finding a way to fix the issue.

@khouloudbelguith
Copy link
Contributor

khouloudbelguith commented Jul 16, 2019 •
edited

Hi @Adyku, @m3ss3ng3rAC,

This issue occurs after an upgrade from PS1.7.6.0.
Here's the PR: #14664 to fix the issue.
Your issue is a duplicate of #14608
Thanks!

@khouloudbelguith
Copy link
Contributor

Duplicate of #14608

@khouloudbelguith khouloudbelguith marked this as a duplicate of #14608 Jul 16, 2019
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 16, 2019

@khouloudbelguith This is a different issue, isn't it? I have a fresh install of 1.7.6 final.

@khouloudbelguith
Copy link
Contributor

@Hlavtox, could you please check your database => table ps_currency & check the precision.

Thanks!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 16, 2019 •
edited by khouloudbelguith

@khouloudbelguith It was 0, I set it back to 2 and still the same issue.

This is not about the decimal points. Do you see the thousands separator? I added it to the text description and issue title.

teka

@khouloudbelguith
Copy link
Contributor

@Hlavtox, thanks for your feedback.
Yes, I have the same issue with PS1.7.6.0 & PS1.7.5.2 and the ps_facetedsearch v3.1.0.
image

It should be like this format
12 345,67 Kč

With PS1.7.6.0 & ps_facetedsearch v2.2.1 => OK

image

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

@khouloudbelguith khouloudbelguith added 1.7.5.2 Affects versions CLDR Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Ready Status: Issue is ready to be worked on and removed NMI Status: issue needs more information labels Jul 16, 2019
@khouloudbelguith
Copy link
Contributor

ping @PierreRambaud

@khouloudbelguith khouloudbelguith marked this as not a duplicate of #14608 Jul 16, 2019
@marionf marionf added the FO Category: Front Office label Jul 16, 2019
@marionf marionf added this to Backlog in PrestaShop 1.7.6 via automation Jul 16, 2019
@marionf marionf moved this from Backlog to To do in PrestaShop 1.7.6 Jul 16, 2019
@PierreRambaud PierreRambaud mentioned this issue Jul 17, 2019
Merged
@PierreRambaud
Copy link
Contributor

Fixed for 1.7.6 here: PrestaShop/ps_facetedsearch#115

@marionf marionf removed this from To do in PrestaShop 1.7.6 Jul 17, 2019
@prestonBot prestonBot mentioned this issue Jul 18, 2019
Open
85 tasks
@sarahdib sarahdib added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Jul 23, 2019
@sarahdib sarahdib added this to the 1.7.6.1 milestone Jul 23, 2019
@sarahdib sarahdib added this to Backlog in PrestaShop 1.7.6 via automation Jul 23, 2019
@sarahdib sarahdib moved this from Backlog to To be reviewed in PrestaShop 1.7.6 Jul 23, 2019
@sarahdib sarahdib moved this from To be reviewed to To be merged in PrestaShop 1.7.6 Jul 23, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Jul 26, 2019
@khouloudbelguith khouloudbelguith mentioned this issue Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreRambaud PierreRambaud

Labels
1.7.5.2 Affects versions 1.7.6.0 Affects versions Bug Type: Bug CLDR Faceted search Module: ps_facetedsearch Fixed Resolution: issue closed because fixed FO Category: Front Office Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression
Projects
No open projects
PrestaShop 1.7.6
  
Done
Milestone
1.7.6.1
Development

No branches or pull requests
7 participants
@PierreRambaud @sarahdib @Hlavtox @marionf @khouloudbelguith @mariem-abid @m3ss3ng3rAC