Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faceted search bad currency format - thousands separator #14657

Closed
Hlavtox opened this issue Jul 15, 2019 · 14 comments

Comments

@Hlavtox
Copy link

commented Jul 15, 2019

Describe the bug
Price amount in faceted price filter has a different format then the store. It contains comma instead of space as a THOUSAND SEPARATOR.

Language: Czech
Currency: Kč (CZK)

Store: 1 000 Kč
Filter: 1,000 Kč

Screenshots
currency

Note
Achieved zero decimals by changing precision from 2 to 0 in ps_currency. No files related to this are modified.

Additional information
PrestaShop version: 1.7.6

@mariem-abid

This comment has been minimized.

Copy link

commented Jul 15, 2019

Hi @Hlavtox,

Which country is selected for the installation of your shop?

@Hlavtox

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

@mariem-abid Czech Republic

@mariem-abid

This comment has been minimized.

Copy link

commented Jul 15, 2019

@Hlavtox, I did not manage to reproduce the issue with PS:1.7.6.0
I attached a video record
https://drive.google.com/file/d/1p8p4etxnYsx6RN9N3MAn8WQPpgc9nYRg/view

Thanks for check and feedback.

@Hlavtox

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

@mariem-abid I am talking about the thousands separator. Make a product with a price over 1000,00 and you will see the error

@ghost

This comment has been minimized.

Copy link

commented Jul 15, 2019

Hello,
I have a pretty similar issue, I am getting 6 decimals, instead of just 2.

@Hlavtox Hlavtox changed the title Faceted search bad currency format Faceted search bad currency format - thousands separator Jul 15, 2019

@m3ss3ng3rAC

This comment has been minimized.

Copy link

commented Jul 16, 2019

Hi,
same issue here: 6 decimals instead of 2. I've been digging for hours in the php and js files without finding a way to fix the issue.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Hi @Adyku, @m3ss3ng3rAC,

This issue occurs after an upgrade from PS1.7.6.0.
Here's the PR: #14664 to fix the issue.
Your issue is a duplicate of #14608
Thanks!

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Duplicate of #14608

@khouloudbelguith khouloudbelguith marked this as a duplicate of #14608 Jul 16, 2019

@Hlavtox

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

@khouloudbelguith This is a different issue, isn't it? I have a fresh install of 1.7.6 final.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@Hlavtox, could you please check your database => table ps_currency & check the precision.

Thanks!

@Hlavtox

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

@khouloudbelguith It was 0, I set it back to 2 and still the same issue.

This is not about the decimal points. Do you see the thousands separator? I added it to the text description and issue title.

teka

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@Hlavtox, thanks for your feedback.
Yes, I have the same issue with PS1.7.6.0 & PS1.7.5.2 and the ps_facetedsearch v3.1.0.
image

It should be like this format
12 345,67 Kč

With PS1.7.6.0 & ps_facetedsearch v2.2.1 => OK

image

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@khouloudbelguith khouloudbelguith marked this as not a duplicate of #14608 Jul 16, 2019

@marionf marionf added the FO label Jul 16, 2019

@marionf marionf added this to Backlog in PrestaShop 1.7.6 via automation Jul 16, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Fixed for 1.7.6 here: PrestaShop/ps_facetedsearch#115

@marionf marionf removed this from To do in PrestaShop 1.7.6 Jul 17, 2019

@prestonBot prestonBot referenced this issue Jul 18, 2019
29 of 34 tasks complete

@sarahdib sarahdib added Fixed and removed To Do labels Jul 23, 2019

@sarahdib sarahdib added this to the 1.7.6.1 milestone Jul 23, 2019

@sarahdib sarahdib added this to Backlog in PrestaShop 1.7.6 via automation Jul 23, 2019

@sarahdib sarahdib moved this from Backlog to To be reviewed in PrestaShop 1.7.6 Jul 23, 2019

@sarahdib sarahdib moved this from To be reviewed to To be merged in PrestaShop 1.7.6 Jul 23, 2019

PrestaShop 1.7.6 automation moved this from To be merged to Done Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.