Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anchor in URL for products #16413

Closed
yannicka opened this issue Nov 14, 2019 · 4 comments
Closed

Remove anchor in URL for products #16413

yannicka opened this issue Nov 14, 2019 · 4 comments
Labels
CO Category: Core Duplicate Resolution: issue closed because already reported Improvement Type: Improvement

Comments

@yannicka
Copy link
Contributor

yannicka commented Nov 14, 2019

Is this anchor needed?

$anchor = $ipa ? $product->getAnchor((int) $ipa, (bool) $addAnchor) : '';

I've replaced this line by:

$anchor = '';

And everything seems to be working fine.

This anchor generates a URL that seems longer than necessary. Perhaps this anchor should be removed or an option should be given to enable/disable it globally if necessary (as suggested in #11041)?

@khouloudbelguith
Copy link
Contributor

khouloudbelguith commented Nov 14, 2019

Hi @yannicka,

Thanks for your report.
@yannicka, Would you be willing to make a pull request on GitHub with your code suggestion?
https://github.com/PrestaShop/PrestaShop/tree/develop

Ping @PrestaShop/prestashop-core-developers, @PrestaShop/prestashop-product-team what do you think?

Thanks!

@khouloudbelguith khouloudbelguith added CO Category: Core Improvement Type: Improvement Waiting for dev Status: action required, waiting for tech feedback labels Nov 14, 2019
@yannicka
Copy link
Contributor Author

I'm able to make a pull request with my suggestion, but I think it's too naive. It would be best to have a setting to enable/disable this.

@khouloudbelguith khouloudbelguith added the Waiting for PM Status: action required, waiting for product feedback label Nov 15, 2019
@khouloudbelguith
Copy link
Contributor

Hi @yannicka,

Your ticket is a duplicate of #11041
So, I close it.
Thanks!

@khouloudbelguith
Copy link
Contributor

Duplicate of #11041

@khouloudbelguith khouloudbelguith marked this as a duplicate of #11041 Feb 28, 2020
@khouloudbelguith khouloudbelguith added Duplicate Resolution: issue closed because already reported and removed Waiting for PM Status: action required, waiting for product feedback Waiting for dev Status: action required, waiting for tech feedback labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CO Category: Core Duplicate Resolution: issue closed because already reported Improvement Type: Improvement
Projects
None yet
Development

No branches or pull requests

2 participants