New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to remove anchor from product link when using URL smarty helper function #11041
Comments
Hi @tlhuillier, Thanks for your report. |
Edit: |
Hi, @tlhuillier, So do you want to delete the IDs from the URL? |
Hello @tlhuillier , Thanks for your feedback. Unfortunately, it's not easy to move from one URL format to another during minor versions as there are risks to break things down when upgrading. We will be rethinking the URL format for the next major version. Do not hesitate to share your ideas ! Regards, |
Hi, As suggested by @yannicka in this issue: #16413
I've replaced this line by: $anchor = ''; And everything seems to be working fine. This anchor generates a URL that seems longer than necessary. Perhaps this anchor should be removed or an option should be given to enable/disable it globally if necessary Thanks! |
Hi everyone, We should be able to remove anchor when it's not needed 👍 |
@PierreRambaud you can check this PR maybe you will find a way to avoid BC break 👍 |
I think I have an idea :) Thanks |
When creating a product link (with product attribute) from the Smarty helper function
url
, it is not possible to define wether or not to add the anchor at the end or the URL.https://your-website.com/cat/1-1-product.html#/product-attribute
It is possible to do so when using directly the instance of
Link
object, but it's deprecated.We should add the anchor parameter to the
url
Smarty helper function.The text was updated successfully, but these errors were encountered: