Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] [FO] SEF URL scheme not working anymore from version 1.5.3 #181

Closed
ldecoker opened this issue Jan 15, 2013 · 3 comments
Closed

[-] [FO] SEF URL scheme not working anymore from version 1.5.3 #181

ldecoker opened this issue Jan 15, 2013 · 3 comments
Labels
< 1.7.x Affects versions

Comments

@ldecoker
Copy link
Contributor

Even if you define custom SEF URL scheme, the dispatcher always use the default one.
This is due to a modification in the Dispatcher class - function loadRoutes(): the default routes are loaded in the routes array after the custom ones and so custom ones are overwritten.

In 1.5.2, default routes were loaded at first step of this method.

@ldecoker
Copy link
Contributor Author

This is quite blocking for those using SEF.

@ldecoker
Copy link
Contributor Author

Ok think I have found a fix for this issue. When loading the default routes, it's missing a test to see if a custom one is not present already in the routes object:

// Set default routes
foreach (Language::getLanguages() as $lang)
foreach ($this->default_routes as $id => $route)
if (!isset($this->routes[$lang['id_lang']][$id]))
$this->addRoute(
$id,
$route['rule'],
$route['controller'],
$lang['id_lang'],
$route['keywords'],
isset($route['params']) ? $route['params'] : array()
);

ldecoker added a commit to ldecoker/PrestaShop that referenced this issue Jan 24, 2013
ldecoker added a commit to ldecoker/PrestaShop that referenced this issue Jan 24, 2013
[-] [FO] SEF URL scheme not working anymore from version 1.5.3 (PrestaShop#181)
@marionf marionf added the < 1.7.x Affects versions label Aug 22, 2018
@marionf
Copy link
Contributor

marionf commented Aug 22, 2018

Hello,
This issue is old, so I close it.
If you still have it on the last version (PrestaShop 1.7.4.2), please open a new one.
Regards

@marionf marionf closed this as completed Aug 22, 2018
marionf pushed a commit to marionf/PrestaShop that referenced this issue Oct 8, 2021
…domain-tag

Remove trans_default_domain tag and rely on module translations only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
< 1.7.x Affects versions
Projects
None yet
Development

No branches or pull requests

2 participants