Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps_contactinfo module improvements #18928

Closed
Laimonas-Mituzas opened this issue May 1, 2020 · 6 comments · Fixed by #25067
Closed

ps_contactinfo module improvements #18928

Laimonas-Mituzas opened this issue May 1, 2020 · 6 comments · Fixed by #25067
Labels
1.7.6.5 Affects versions Contactinfo Module: contactinfo Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end Good first issue Community: beginner-friendly issues Improvement Type: Improvement PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed

Comments

@Laimonas-Mituzas
Copy link

Laimonas-Mituzas commented May 1, 2020

New description

I'd like to extend the original issue, the original issue title is flexible enough to make this seem possible.

Is your feature request related to a problem?

  • The phone number provided to front page by module ps_contactinfo is not clickable. Using smartphone it is comfortable that phone number is active, the same as email address.
  • The eMail Address should be encoded to be protected against SPAM bots

Describe the solution you'd like

Alternatives you've considered
none

Additional context
none

Original description :
The phone number provided to front page by module ps_contactinfo is not clickable.
Using smartphone it is comfortable that phone numer is active, the same as email address.

@prestashop-issue-bot
Copy link

Thanks for opening this issue! We will help you to keep its state consistent

@florine2623
Copy link
Contributor

Hi @Laimonas-Mituzas ,

Thanks for the suggestion, I will let our product team know about your request.

@florine2623
Copy link
Contributor

Hi @PrestaShop/prestashop-product-team !

What do you think about this improvement on module ps_contactinfo ?
On v3.1.0, on mobile, phone number and email can't be clicked to shoot an action.

Thanks!

@florine2623 florine2623 added 1.7.6.5 Affects versions Contactinfo Module: contactinfo FO Category: Front Office Improvement Type: Improvement Waiting for PM Status: action required, waiting for product feedback labels May 4, 2020
@LouiseBonnard
Copy link
Contributor

Nice improvement, @Laimonas-Mituzas, thanks! Indeed, when on a desktop device, the email address is clickable, it makes sense to allow the same when on a mobile device (including the phone number).

@LouiseBonnard LouiseBonnard added Good first issue Community: beginner-friendly issues PM ✔️ Status: check done, behavior approved Ready Status: Issue is ready to be worked on and removed Waiting for PM Status: action required, waiting for product feedback labels May 4, 2020
@ziegenberg
Copy link
Contributor

I'd like to extend the original issue, the original issue title is flexible enough to make this seem possible.

Is your feature request related to a problem?

  • The phone number provided to front page by module ps_contactinfo is not clickable. Using smartphone it is comfortable that phone number is active, the same as email address.
  • The eMail Address should be encoded to be protected against SPAM bots

Describe the solution you'd like

Alternatives you've considered

none

Additional context

none

@LouiseBonnard LouiseBonnard added the PR available Solution: issue is being addressed label Jun 22, 2020
@sarahdib sarahdib removed the Ready Status: Issue is ready to be worked on label Sep 1, 2020
@sarahdib sarahdib added this to To do in Native modules integration via automation Sep 1, 2020
@sarahdib sarahdib moved this from To do to To be merged in Native modules integration Sep 1, 2020
@marionf marionf added the Front-end Category: Front end label Oct 26, 2020
@matks matks changed the title ps_contactinfo upgrade ps_contactinfo module improvements Mar 29, 2021
@florine2623
Copy link
Contributor

Ping @PrestaShop/product-team ,

FYI, part of this issue is fixed by @henri9813 's PR : #25067

@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Jul 9, 2021
Native modules integration automation moved this from To be merged to Done Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.6.5 Affects versions Contactinfo Module: contactinfo Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end Good first issue Community: beginner-friendly issues Improvement Type: Improvement PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed
Projects
7 participants