Wrong cart rule amount in FO when "Exclude discounted products" is enabled

[kenlog]

Describe the bug

When applying a cart rule with "exclude discounted products" enabled, the amount of the cart rule line isn't ok
It takes into account all products instead of only not discounted products
But the total and the discount line are OK

Steps to Reproduce

1. I created a cart rule of 10% and enabled "exclude discounted products"
2. I added two products in my cart: Hummingbird printed sweater, Size S (discounted) and Mug The best is yet to come (not discounted)
3. See the discount line is OK, the total is OK but the cart rule line isn't OK

Expected behavior

If you activate the rule "Exclude discounted products" I expect that discount will not be applied to products that are discounted, but only to products without discount.

Additional information

• PrestaShop version: 1.7.6.4
• PHP version: 7.2

[prestashop-issue-bot]

Thanks for opening this issue! We will help you to keep its state consistent

[florine2623]

Hi @kenlog ,
Thanks for reporting this issue.
I managed to reproduce the issue on both PS 1.7.6.5 and PS 1.7.7.
I'll let our dev team know about it.
Please stay tuned, thanks !

[arouiadib]

Hello guys,

In 1.7.7.x, the calculation is correct.

Thanks

[sarahdib]

@kenlog Thank you for the report I manage to reproduce the issue
You can see in my screenshot the value of the cart rule is not the same that the one in the cart. The total is correct only the display is not correct

[arouiadib]

@sarahdib , thank you for your time.
About the second part (your second red rectangle), the problem should theoretically be fixed today after the merge of #17502 (Although it is not the problem originally mentioned by @kenlog; as you can see from his original picture when still voucher were displayed as percent). I will test with current 1.7.7.x state and feedback.

I think @kenlog is talking about the first part (your first red rectangle). Then, there is no problem as you see :) in your picture:

3.48 is 10% of 34.80, then the product which already discounted (Pull imprime colibri) is not included in the overall discount calculcation.

I am of course talking about 1.7.7.x, so IMHO it is just a question of upgrading.
Thanks.

[sarahdib]

@arouiadib Thank you for those detail :)

@kenlog can you confirm ?

[kenlog]

Hi @sarahdib I confirm the bug as I have exposed it. In addition, this is also reflected in the PayPal payment method which correctly charges the right price excluding the already discounted products. This obviously involves a difference in the total cart and the order total. 😲

P.S. Other payment methods such as Stripe charges based on the total cart.

[ComonSoft]

Hi,
This is a big issue, because invoices are false, and customer can complain. Is any fix available ?
To reproduce, add rule 10% all cart exclude products in promotion. The reduction is applied on all products. See screen shot enclosed.
PS 1.7.6.5 PHP 7.2

Regards

[Damian-Rutkowski]

Good afternoon,

is there an official patch that can also be imported for older versions (e.g. v1.7.6.5)? We have some customers and unfortunately we cannot update all of them.

[khouloudbelguith]

Hi!

As commented here, I have the same issue with PS1.7.7.0beta2build1

Thanks!

[marionf]

@hibatallahAouadni

Just tested on 1.7.7.x branch and this issue doesn't seems fixed

1. I created a cart rule of 10% and excluded discounted products
2. I added to products in my cart: Hummingbird printed sweater, Size S (discounted) and Mug The best is yet to come (not discounted)

[hibatallahAouadni]

Hello @marionf

Could you please check the screen record attached below:

https://drive.google.com/file/d/1wzBKm-ltqVdo35Cihv34lgFMQSxHR8ha/view

Please check and feedback.
Thanks!

[marionf]

That's another issue, you added a condition in the cart rule and selected a category: #22057
Here, there is still the issue described by @khouloudbelguith in this comment with a cart rule with "exclude discounted products" enabled and no conditions

[GIORGIOMARIO]

Discount voucher problem: The discount code applies to all products, even to discounted items with the version 1.7.6.5.

When I apply the discount code on 1 item, the code does "exclude discounted products".
But when I apply it on more than 1 item (1 normal and 1 disounted product per example), the code apply reduction on all products.

[josearandac]

Hello,

This solution work for me.

1. File /src/Core/Cart/CartRuleCalculator.php find the code block:

        if ($cartRule->reduction_percent && $cartRule->reduction_product == -2) {
            $selected_products = $cartRule->checkProductRestrictionsFromCart($cart, true);
            if (is_array($selected_products)) {
                foreach ($this->cartRows as $cartRow) {
                    $product = $cartRow->getRowData();
                    if (in_array($product['id_product'] . '-' . $product['id_product_attribute'], $selected_products)
                        || in_array($product['id_product'] . '-0', $selected_products)
                           && (($cartRule->reduction_exclude_special && !$product['reduction_applies'])
                               || !$cartRule->reduction_exclude_special)) {
                        $amount = $cartRow->applyPercentageDiscount($cartRule->reduction_percent);
                        $cartRuleData->addDiscountApplied($amount);
                    }
                }
            }
        }

2. We add a parenthesis:

        // Discount (%) on the selection of products
        if ($cartRule->reduction_percent && $cartRule->reduction_product == -2) {
            $selected_products = $cartRule->checkProductRestrictionsFromCart($cart, true);
            if (is_array($selected_products)) {
                foreach ($this->cartRows as $cartRow) {
                    $product = $cartRow->getRowData();
                    if ((in_array($product['id_product'] . '-' . $product['id_product_attribute'], $selected_products)
                        || in_array($product['id_product'] . '-0', $selected_products))
                           && (($cartRule->reduction_exclude_special && !$product['reduction_applies'])
                               || !$cartRule->reduction_exclude_special)) {
                        $amount = $cartRow->applyPercentageDiscount($cartRule->reduction_percent);
                        $cartRuleData->addDiscountApplied($amount);
                    }
                }
            }
        }

I hope it helps

[hibatallahAouadni]

Hello @josearandac

Could you please create a Pull Request.
Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

[josearandac]

Hello @hibatallahAouadni ,

A pull request already exists:

18144

I just found it.

Thank you!

[khouloudbelguith]

Hi @marionf,

As commented here, the issue is fixed

177x (1775 => ok): https://drive.google.com/file/d/1wIIN_4lgP13CqVA0OSgcRkDS9yAXTEnH/view?usp=sharing
178x => ok

Thank you!