Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest Order Tracking redirects to shop Homepage when Friendly URLs are disabled #20194

Closed
Tracked by #19543
SuichiM opened this issue Jul 16, 2020 · 4 comments · Fixed by #20338
Closed
Tracked by #19543

Guest Order Tracking redirects to shop Homepage when Friendly URLs are disabled #20194

SuichiM opened this issue Jul 16, 2020 · 4 comments · Fixed by #20338
Labels
1.7.6.5 Affects versions 1.7.6.7 Affects versions 1.7.7.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Major Severity: major bug > https://build.prestashop.com/news/severity-classification SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned
Milestone

Comments

@SuichiM
Copy link
Contributor

SuichiM commented Jul 16, 2020

Describe the bug

I'm using prestashop 1.7.6.5 with the classic theme and when I want to follow an order as a guest user (with valids order_id and email), the form redirect to the main page.

Expected behavior

Show the order history.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to 'index.php?controller=guest-tracking'
  2. Complete the fields with a valid order_id and e-mail
  3. Submit

Possible solution
if I add the follow hidden input to the form, the bug is fixed, but I don't know if is the best solution.

file themes/classic/templates/customer/guest-login.tpl

<input type="hidden" name="controller" value="guest-tracking" >

If this is a good solution I could make the PR.

awaiting for feedback...

Additional information

  • PrestaShop version: 1.7.6.5
  • PHP version: 5.6
@prestashop-issue-bot
Copy link

Thanks for opening this issue! We will help you to keep its state consistent

@khouloudbelguith
Copy link
Contributor

Hi @SuichiM,

Thanks for your report.
I think your issue is simar to this ticket: #15605 fixed with this PR: #16872
Thanks to check it and feedback.

@khouloudbelguith khouloudbelguith added the Waiting for author Status: action required, waiting for author feedback label Jul 16, 2020
@SuichiM
Copy link
Contributor Author

SuichiM commented Jul 16, 2020

I don't believe that is the same bug. In my case I just try with a never-used email (never registered as user). And have the same bug.

my problem, seems to be a malformed url when submit the form (lost the controller param)
...
index.php?order_reference=FJMGFENOB&email=testingmail%40ageokfc.com

instead of:
index.php?controller=guest-tracking&order_reference=FJMGFENOB&email=testingmail%40ageokfc.com

@florine2623 florine2623 added the NMI Status: issue needs more information label Jul 16, 2020
@florine2623
Copy link
Contributor

Hi @SuichiM ,

Thanks for your report. I did manage to reproduce the issue in PS 1.6.7.5 and PS 1.7.7.0.

  • Disable friendly URL
  • Go to 'index.php?controller=guest-tracking'
  • Complete the fields with a valid order_id and e-mail
  • Submit
  • Redirect to shop home page instead of Guest Tracking page :

Capture d’écran 2020-07-24 à 15 03 01

If you have a PR you can submit it !
Thanks.

FYI : When Friendly URL are enabled, the bug does not occur.

@florine2623 florine2623 added 1.7.6.5 Affects versions 1.7.6.7 Affects versions 1.7.7.0 Affects versions Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on and removed NMI Status: issue needs more information Waiting for author Status: action required, waiting for author feedback labels Jul 24, 2020
@florine2623 florine2623 changed the title guest-tracking form of the classic theme don't work Guess Order Tracking redirects to shop Homepage when Friendly URLs are disabled Jul 24, 2020
@florine2623 florine2623 added FO Category: Front Office SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned labels Jul 24, 2020
@florine2623 florine2623 added this to Waiting for classification in Bug classification board Jul 24, 2020
@florine2623 florine2623 removed this from Waiting for classification in Bug classification board Jul 24, 2020
SuichiM added a commit to SuichiM/PrestaShop that referenced this issue Jul 24, 2020
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Sep 25, 2020
@khouloudbelguith khouloudbelguith added this to Not ready in PrestaShop 1.7.8.0 via automation Sep 25, 2020
@khouloudbelguith khouloudbelguith added this to the 1.7.8.0 milestone Sep 25, 2020
@khouloudbelguith khouloudbelguith moved this from Not ready to To be merged in PrestaShop 1.7.8.0 Sep 25, 2020
PrestaShop 1.7.8.0 automation moved this from To be merged to Done Sep 25, 2020
@matks matks changed the title Guess Order Tracking redirects to shop Homepage when Friendly URLs are disabled Guest Order Tracking redirects to shop Homepage when Friendly URLs are disabled Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.6.5 Affects versions 1.7.6.7 Affects versions 1.7.7.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Major Severity: major bug > https://build.prestashop.com/news/severity-classification SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants