Error during manual order state change

[Flower7C3]

Describe the bug

When I manually change order state an error occurs:

[Symfony\Component\Debug\Exception\ContextErrorException kod 0]: Notice: Trying to get property 'id' of non-object

Expected behavior

Method \OrderCore::getCurrentOrderState:

PrestaShop/classes/order/Order.php

Lines 2332 to 2339 in cc0fd12

	public function getCurrentOrderState()
	{
	if ($this->current_state) {
	return new OrderState($this->current_state);
	}
	return null;
	}

should have following code:

    public function getCurrentOrderState()
    {
        if ($this->current_state !== "") {
            return new OrderState($this->current_state);
        }

        return null;
    }

Steps to Reproduce

Steps to reproduce the behavior:

1. Go to orders list
2. Change order status to cancelled
3. See error on top

Additional information

• PrestaShop version: 1.7.7.0
• PHP version: 7.3.24

[hibatallahAouadni]

Hello @Flower7C3

I didn't manage to reproduce your issue with PS1.7.7.0, see the attached screen record below:

https://drive.google.com/file/d/1Uf2yTmgH3G5R1s69W6CVLkUIQQYe29xU/view

Please check and feedback.

Thanks!

[Flower7C3]

@hibatallahAouadni do You have same PHP version?

[hibatallahAouadni]

No my PHP version is 7.2 😅

[hibatallahAouadni]

Hello @Flower7C3

Is this the error that you encountred?

Thanks for your feedback!

[Flower7C3]

No, I have got other message:

[Symfony\Component\Debug\Exception\ContextErrorException kod 0]: Notice: Trying to get property 'id' of non-object

[hibatallahAouadni]

Hello @Flower7C3

Did you change some Core files? Cause it seems your issue is not related neither to PS version nor PHP version.

Thanks!

[Flower7C3]

I have changed classes/order/Order.php file as described in issue description.

[hibatallahAouadni]

Hello @Flower7C3

You shouldn't change any of Core files! If you want to change some behavior of Core, you just need to override the Controller (see link).

So, I close the issue cause we use GitHub issues only to discuss about bugs and new features in the PrestaShop project. If you have questions about using PrestaShop or third-party modules, or if you need help with your shop, please consider one of our support plans.

Alternatively, you can also ask for help in the community forums or in the public Slack channel.

Thanks!

[rbeau]

Hi @Flower7C3,
Post #24097
I have same issue. Your bug is fixed ? Could you please explain me how to resolve this bug ? There is no change if I try your solution.
Thanks

[Flower7C3]

Hi @rbeau, I have fixed this problem using overrides directory. All described in 1st comment #22322 (comment)

[rbeau]

You are right @Flower7C3 ,

I understand now, if I still turn Prestashop on mode debug solution doesn't work. Now debug mode is off and it work prefectely.

I thank you so much !