Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a BO admin I want to be able to track changes done from the Back Office #24698

Open
matks opened this issue May 28, 2021 · 8 comments
Open
Labels
BO Category: Back Office Feature Type: New Feature Logs Label: Which BO under menu is concerned Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback

Comments

@matks
Copy link
Contributor

matks commented May 28, 2021

Is your feature request related to a problem?

As a BO admin I want to be able to track changes done from the Back Office. I want to know when a product properties has been updated, when a product has been deleted, when a category was renamed... because sometimes my shop settings are wrong and I want to understand how it ended up in this situation.

Describe the solution you'd like

A way to track changes related to an item of PrestaShop (a product, a category, an order...)

Log entries seem a good way to achieve this.

Additional context

User need reported by @ldeprestashop . @ldeprestashop can you elaborate?

@florine2623 florine2623 added BO Category: Back Office Feature Type: New Feature Logs Label: Which BO under menu is concerned Old Products Page Concerns the old product page NMI Status: issue needs more information labels May 28, 2021
@PululuK
Copy link
Member

PululuK commented May 28, 2021

Hi @matks @ldeprestashop

IMHO I think we need :

I can take this issue 😉

Thanks

@matks
Copy link
Contributor Author

matks commented May 28, 2021

Hi @PululuK indeed your contributions very well match this need 😉 . I think we can think of other items we can add to the list.

One thing I had in mind was to add a logger middleware to our Command and Query Buses: by implementing this, everytime a Command or Query would be dispatched in the software we would get one log.

@PululuK
Copy link
Member

PululuK commented May 28, 2021

Yeah ! I like the idea @matks
The problem of the logs that they fill up very quickly, I'm afraid that the log table will explode. Should we perhaps analyze the relevance of the actions to be logged?

@PululuK PululuK added the Improvement Type: Improvement label May 28, 2021
@hibatallahAouadni hibatallahAouadni added Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback and removed Feature Type: New Feature NMI Status: issue needs more information Old Products Page Concerns the old product page labels May 28, 2021
@Hlavtox
Copy link
Contributor

Hlavtox commented May 29, 2021

Hi everyone, my 5 cents to this topic. THIS IS EXTREMELY GOOD IDEA AND IMPORTANT THING. 👍 👍 👍

Even with only few employees, as a boss, you need to know who did this or who screwed up that. In our ERP, every single action on every single object is logged - date and time, employee, what data changed, previous state and final state. Can't imagine living without it in those "how the hell this happened" cases.

I think that the current Prestashop log system can be used for that (except for precise previous/current states - can be limited to "product->description changed"), but it needs to be configurable and a regular cleaning system should be made. We grew our ERP DB to 10 GB in first year and a half, mainly because of logs. 😄

@micka-fdz
Copy link
Contributor

+1 for this good idea ! Very useful for agencies like us to know if errors come from us or merchants 😂

@ldeprestashop
Copy link

@matks Ye I can make a specification.

Just wait 2 week, I must focus on Product days and finish strategics plan before ;)

@jolelievre
Copy link
Contributor

Log entries might be a bit simple for this feature, I guess the ideal would be a true Event sourcing feature that would be saved in DB with dates, associated action/customer/employee/...

@matks
Copy link
Contributor Author

matks commented Jun 30, 2021

Log entries might be a bit simple for this feature, I guess the ideal would be a true Event sourcing feature that would be saved in DB with dates, associated action/customer/employee/...

PrestaShop logs is a SQL table which contain all that. I should have been clearer 😅 I was thinking about this kind of logs not text file logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Feature Type: New Feature Logs Label: Which BO under menu is concerned Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback
Projects
None yet
Development

No branches or pull requests

9 participants